Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove duplicate import statements #343

Merged
merged 2 commits into from
Oct 10, 2022
Merged

fix: remove duplicate import statements #343

merged 2 commits into from
Oct 10, 2022

Conversation

Ankitchaudharyy
Copy link
Contributor

Description
Remove duplicate import statement for GleeMessage.js

Related issue(s)

Resolves #338

github-actions[bot]
github-actions bot reviewed Oct 10, 2022
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@Ankitchaudharyy Ankitchaudharyy changed the title Remove duplicate import statements fix: remove duplicate import statements Oct 10, 2022
fmvilas
fmvilas previously approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks a lot! 🙌

@coveralls
Copy link

coveralls commented Oct 10, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3218973638

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.796%
Totals Coverage Status
Change from base Build 3218359258: 0.0%
Covered Lines: 286
Relevant Lines: 300
💛 - Coveralls

@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@fmvilas
Copy link
Member

fmvilas commented Oct 10, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit 46fce4a into asyncapi:master Oct 10, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.10.25 🎉

The release is available on:

Your semantic-release bot 📦🚀

@fmvilas fmvilas mentioned this pull request Oct 10, 2022
Closed
Ruchip16 pushed a commit to Ruchip16/glee that referenced this pull request Jan 12, 2023
@Ankitchaudharyy @ankitchaudharyy-TW @Ruchip16
fix: remove duplicate import statements (asyncapi#343)
1da997e 
Co-authored-by: ankitchaudharyy-TW <[email protected]>
@coveralls
Copy link

coveralls commented Nov 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 3218862879

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.796%
Totals Coverage Status
Change from base Build 3218359258: 0.0%
Covered Lines: 286
Relevant Lines: 300
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@fmvilas fmvilas fmvilas approved these changes

@jonaslagoni jonaslagoni Awaiting requested review from jonaslagoni

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'./message.js' import is duplicated.
5 participants
@Ankitchaudharyy @coveralls @fmvilas @asyncapi-bot @ankitchaudharyy-TW